Adjust footer height #30586
Closed
Adjust footer height #30586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable23 |
|
/backport to stable22 |
nextcloud-command
force-pushed
the
footer-height
branch
from
6755564 to
8f36c79
Compare
|
Feels like @jancborchardt an opinion on this one? It is about the footer at the bottom of public shares and other public views. |
|
@artonge |
This comment was marked as resolved.
This comment was marked as resolved.
|
/rebase |
nextcloud-command
force-pushed
the
footer-height
branch
from
9cb1792 to
9651587
Compare
Merged
Merged
Merged
|
/rebase |
szaimen
requested review from
a team,
PVince81,
artonge and
Pytal
and removed request for
a team
skjnldsv
approved these changes
Apr 7, 2022
szaimen
approved these changes
Apr 7, 2022
szaimen
added
4. to release
nextcloud-command
force-pushed
the
footer-height
branch
from
9651587 to
737a274
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Merged
|
/backport to stable24 |
|
@solracsf can you please squash? Then we can merge :) |
|
🌝
|
|
|
|
Maybe @blizzz can enable such (very useful) option? |
it would result in a fast forward merge, and this is not what we went when merging into master or stable branches. |
Merged
|
/rebase |
65px is not enough when you have 3 lines (Cloud name, Legal notice and Signup link)
nextcloud-command
force-pushed
the
footer-height
branch
from
737a274 to
9b2bb20
Compare
Merged
Merged
|
Closing and moving to #34391 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
65px is not enough when you have 3 lines (Cloud name, Legal notice and Signup link)