Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sub-admins to access delegated settings. #30926

Merged
merged 1 commit into from
Jan 31, 2022
Merged

Allow sub-admins to access delegated settings. #30926

merged 1 commit into from
Jan 31, 2022

Conversation

rotdrop
Copy link
Contributor

@rotdrop rotdrop commented Jan 30, 2022 •
edited by szaimen
Loading

Close #30927

@rotdrop rotdrop mentioned this pull request Jan 30, 2022
Closed
@szaimen szaimen requested review from CarlSchwan, artonge, a team, icewind1991 and blizzz and removed request for a team January 31, 2022 06:43
@szaimen szaimen added 3. to review Waiting for reviews enhancement labels Jan 31, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Jan 31, 2022
@artonge
Copy link
Contributor

artonge commented Jan 31, 2022

@rotdrop your commit needs DCO :)

@rotdrop
Allow sub-admins to access delegated settings.
a234217 
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
@rotdrop rotdrop force-pushed the bugfix/settings-delegation-for-subadmins branch from e9eb74e to a234217 Compare January 31, 2022 13:09
@rotdrop
Copy link
Contributor Author

rotdrop commented Jan 31, 2022

OK, I have signed the commit and force-pushed it to my fork.

@artonge
Copy link
Contributor

artonge commented Jan 31, 2022

CI failure unrelated

@artonge artonge merged commit b47a42f into nextcloud:master Jan 31, 2022
@welcome
Copy link

welcome bot commented Jan 31, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@artonge
Copy link
Contributor

artonge commented Jan 31, 2022

Thanks @rotdrop ! :)

@CarlSchwan
Copy link
Member

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 10, 2022
Merged
@gmaxbass
Copy link

Hi, I've a similar need: letting a sub admin promote a normal user to sub admin (sub admin delegation) within the same group.
I'm wondering if this pull-request covers this case delegating a sub-admin to administer only specific group(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@blizzz blizzz Awaiting requested review from blizzz

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

SubAdmins cannot access delegated admin settings???
5 participants
@rotdrop @artonge @CarlSchwan @gmaxbass @szaimen