Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs with incorrect currentFileList in the favorite and share by you view #30995

Merged

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Feb 3, 2022

This was causing bugs when trying to create a new template in these views

Steps to reproduce original bug

  • Go to "shared with you" folder
  • Enter one of the folder inside of it
  • Try to create a template
  • Get an error notification as the path the js frontend is sending is null

view

This was causing bugs when trying to create new template in this views

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Feb 3, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 24 milestone Feb 3, 2022
@CarlSchwan CarlSchwan requested a review from a team February 3, 2022 19:09
@CarlSchwan CarlSchwan self-assigned this Feb 3, 2022
@CarlSchwan CarlSchwan requested review from PVince81, skjnldsv and szaimen and removed request for a team February 3, 2022 19:09
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it looks good but maybe you could add some steps how to reproduce in order to make testing easier?

@CarlSchwan
Copy link
Member Author

I guess it looks good but maybe you could add some steps how to reproduce in order to make testing easier?

done ;)

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works

@szaimen szaimen added the bug label Feb 4, 2022
@szaimen
Copy link
Contributor

szaimen commented Feb 4, 2022

@CarlSchwan does this need backports?

@CarlSchwan
Copy link
Member Author

/backport to stable23

@CarlSchwan
Copy link
Member Author

/backport to stable22

@CarlSchwan
Copy link
Member Author

/backport to stable21

@szaimen
Copy link
Contributor

szaimen commented Feb 7, 2022

Failing tests are unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants