Improve user status revert performance #31106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
bug
2. developing
|
at least the first/first-two commits should be backported to 23 |
3 tasks
nickvergessen
commented
Feb 10, 2022
nickvergessen
force-pushed
the
techdebt/noid/improve-user-status-update-handling
branch
2 times, most recently
from
99f51e9
to
cd31725
Compare
nickvergessen
added
3. to review
nickvergessen
requested review from
CarlSchwan,
a team,
juliusknorr,
skjnldsv and
PVince81
and removed request for
a team
CarlSchwan
approved these changes
Feb 14, 2022
8 tasks
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…d of 3*n Signed-off-by: Joas Schilling <coding@schilljs.com>
…ser_id leading underscore already Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
techdebt/noid/improve-user-status-update-handling
branch
from
e1aa54b
to
058d1de
Compare
|
Also reduced inserting the status from 7 to 2-3 queries as described in #31190 |
|
3 way comparison in talks integration test of the query log makes it obvious:
|
CarlSchwan
approved these changes
Feb 16, 2022
|
Drone tests isn't necessary? |
PVince81
reviewed
Feb 23, 2022
| if (!$userStatus->getIsBackup() | ||
| && $userStatus->getMessageId() === $messageId | ||
| && $userStatus->getStatus() === $status) { | ||
| $statuesToDelete[$userStatus->getUserId()] = $userStatus->getId(); |
nickvergessen
deleted the
techdebt/noid/improve-user-status-update-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a meeting in Talk is ended for everyone the database basically dies. One of the problems is resetting the user status:
Queries before "5 per user"
revertUserStatusrevertUserStatusremoveUserStatusremoveUserStatusrevertUserStatusPlan level 1: Improve current function: "3 per user"
revertUserStatus: ☑️revertUserStatus: 💥 Remove by adding a delete which has the matching parametersremoveUserStatus: 💥 Removed in this PRremoveUserStatus: ☑️revertUserStatus: ☑️Plan level 2: Add special handling for "End call for everyone": "3 in total"
Plan level 3
using WHERE=> removed from query as the leading underscore ensures it's value alreadyFix #31190