Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix a broken tooltip #31170

Merged
merged 1 commit into from
Feb 15, 2022
Merged

fix a broken tooltip #31170

merged 1 commit into from
Feb 15, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Feb 14, 2022 •
edited
Loading

Steps to reproduce the bug:

  1. create a folder and a subfolder in that folder
  2. share the subfolder via link
  3. click on Shares (in the left sidebar)
  4. See the subfolder that should get listed there
  5. click on this subfolder and get redirected to the subfolder

Before this change:

  1. The tooltip stays and doesn't get removed

After this change:

  1. The tooltip is removed

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=enh/noid/fix-broken-tooltip \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen
try to fix broken tooltip
6d7a0fa 
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen szaimen added bug 2. developing Work in progress labels Feb 14, 2022
@szaimen szaimen added this to the Nextcloud 23.0.3 milestone Feb 14, 2022
@szaimen szaimen added 3. to review Waiting for reviews feature: files and removed 2. developing Work in progress labels Feb 14, 2022
@szaimen szaimen requested review from a team, PVince81, artonge and skjnldsv and removed request for a team February 14, 2022 14:48
@szaimen szaimen marked this pull request as ready for review February 14, 2022 14:48
@szaimen szaimen changed the title try to fix broken tooltip fix a broken tooltip Feb 14, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Feb 14, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Feb 14, 2022

/backport to stable22

@szaimen
Copy link
Contributor Author

szaimen commented Feb 14, 2022

/backport to stable21

artonge
artonge approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would prefer to keep the tooltip and have it disappear correctly, but the 4000 lines of filelist.js are simply depressing 😞

@artonge artonge merged commit 9026455 into master Feb 15, 2022
@artonge artonge deleted the enh/noid/fix-broken-tooltip branch February 15, 2022 10:47
This was referenced Feb 15, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: files
Projects
None yet
Milestone
Nextcloud 23.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@szaimen @artonge @CarlSchwan