Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleaning reminders after subscription purge #31295

Merged
merged 1 commit into from
Feb 22, 2022

Conversation

tcitworld
Copy link
Member

Follow-up to #20766, $subscriptionData['id'] may be a string and cleanRemindersForCalendar only accepts ints.

Also container->query ➡️ container->get.

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Feb 21, 2022
@tcitworld tcitworld added this to the Nextcloud 24 milestone Feb 21, 2022
@tcitworld tcitworld requested review from PVince81, icewind1991 and come-nc and removed request for a team February 21, 2022 10:38
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 21, 2022
@ChristophWurst ChristophWurst merged commit d06716d into master Feb 22, 2022
@ChristophWurst ChristophWurst deleted the fix-cleaning-reminders branch February 22, 2022 09:46
@tcitworld
Copy link
Member Author

Let's wait until #31262 #31263 #31264 are merged before backporting this one.

@tcitworld
Copy link
Member Author

Or add this commit to the backports

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants