Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fileactions for sharing overview #31389

Merged
merged 1 commit into from
Mar 2, 2022
Merged

fix fileactions for sharing overview #31389

merged 1 commit into from
Mar 2, 2022

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Mar 1, 2022 •
edited
Loading

Fix #27671

Signed-off-by: szaimen szaimen@e.mail.de

For my own testing 
docker run -it \
-e SERVER_BRANCH=enh/27671/fix-sharing-overview-actions \
-e VIEWER_BRANCH=master \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.146.128 \
--name nextcloud-easy-test \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added bug 2. developing Work in progress labels Mar 1, 2022
@szaimen szaimen added this to the Nextcloud 24 milestone Mar 1, 2022
@szaimen szaimen force-pushed the enh/27671/fix-sharing-overview-actions branch 2 times, most recently from 4e9d212 to 8b0c22e Compare March 1, 2022 16:43
CarlSchwan
CarlSchwan approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, just need npm run build :)

@szaimen
Copy link
Contributor Author

szaimen commented Mar 2, 2022

/compile amend /

@szaimen
Copy link
Contributor Author

szaimen commented Mar 2, 2022

Thanks Carl! :)

@szaimen @nextcloud-command
try to fix correct fileactions for sharing overview
1bb2534 
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/27671/fix-sharing-overview-actions branch from 8b0c22e to 1bb2534 Compare March 2, 2022 16:00
@szaimen szaimen marked this pull request as ready for review March 2, 2022 16:08
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 2, 2022
@szaimen
Copy link
Contributor Author

szaimen commented Mar 2, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Mar 2, 2022

/backport to stable22

@szaimen szaimen changed the title try to fix correct fileactions for sharing overview fix fileactions for sharing overview Mar 2, 2022
@szaimen szaimen requested review from a team, PVince81, skjnldsv and Pytal and removed request for a team March 2, 2022 19:35
@szaimen
Copy link
Contributor Author

szaimen commented Mar 2, 2022

Failure unrelated, afaics (timeout)

@szaimen szaimen merged commit 0f34bce into master Mar 2, 2022
@szaimen szaimen deleted the enh/27671/fix-sharing-overview-actions branch March 2, 2022 20:54
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 2, 2022

Okay, i am pretty sure now that the backport bot is broken

@szaimen
Copy link
Contributor Author

szaimen commented Mar 3, 2022

/backport to stable23

@szaimen
Copy link
Contributor Author

szaimen commented Mar 3, 2022

/backport to stable22

@szaimen szaimen restored the enh/27671/fix-sharing-overview-actions branch March 3, 2022 12:27
@szaimen szaimen mentioned this pull request Mar 3, 2022
Merged
@szaimen szaimen deleted the enh/27671/fix-sharing-overview-actions branch March 3, 2022 12:32
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@backportbot-nextcloud
Copy link

The backport to stable22 failed. Please do this backport manually.

@szaimen
Copy link
Contributor Author

szaimen commented Mar 3, 2022

done that in #31424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.

Webdav link in share overview instead of openfile link
3 participants
@szaimen @CarlSchwan @Pytal