Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the logger that is imported for critical actions #31454

Merged
merged 1 commit into from
Mar 11, 2022
Merged

Fix the logger that is imported for critical actions #31454

merged 1 commit into from
Mar 11, 2022

Conversation

CarlSchwan
Copy link
Member

Currently it's just using the normal psr logger

Needed for nextcloud/groupfolders#1917

@CarlSchwan CarlSchwan added the bug label Mar 4, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 24 milestone Mar 4, 2022
@CarlSchwan CarlSchwan self-assigned this Mar 4, 2022
@CarlSchwan CarlSchwan mentioned this pull request Mar 4, 2022
Open
@CarlSchwan CarlSchwan requested a review from skjnldsv March 4, 2022 15:06
@CarlSchwan CarlSchwan added the 2. developing Work in progress label Mar 7, 2022
@CarlSchwan
Copy link
Member Author

Unit tests are failing but I'm not sure it's caused by this PR: phpunit: command not found

@nickvergessen
Copy link
Member

Unit tests are failing but I'm not sure it's caused by this PR: phpunit: command not found

The "Set up php 7.4" command errors:

chmod: cannot access '/usr/local/bin/phpunit': No such file or directory
✗ phpunit Could not setup phpunit

I assume this is a temporary bug with actions?

But this here is not:

Bildschirmfoto von 2022-03-07 13-16-07

@CarlSchwan CarlSchwan added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 10, 2022
nickvergessen
nickvergessen approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this fixes a bug, we need to backport it, right?

@CarlSchwan
Copy link
Member Author

As this fixes a bug, we need to backport it, right?

yes

@CarlSchwan
Fix the logger that is imported for critical actions
3e0c42e 
This use a new interface AuditLogger that makes it easier to
seperate the roles of the various loggers and enforce that we
don't use the wrong one by mistake.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
Copy link
Member Author

/backport to stable23

@CarlSchwan
Copy link
Member Author

/backport to stable22

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 11, 2022
@skjnldsv skjnldsv merged commit 3c2aba4 into master Mar 11, 2022
@skjnldsv skjnldsv deleted the fix/audit-log-critical branch March 11, 2022 12:36
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 11, 2022
Merged
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 11, 2022
Merged
@szaimen
Copy link
Contributor

szaimen commented Mar 12, 2022 •
edited
Loading

This PR might have broken
image
in master

@nickvergessen
Copy link
Member

Add the import in 3e0c42e#diff-26f1e4805b227aa0936eaf6b5492ca8b166f852322243fb5d37b0d27e4c30f95R47 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
5 participants
@CarlSchwan @nickvergessen @szaimen @PVince81 @skjnldsv