Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Fix too many file download notifications when watching a video #31485

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #28227

@szaimen
Copy link
Contributor

szaimen commented Mar 8, 2022

/rebase

@szaimen szaimen added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 8, 2022
Signed-off-by: szaimen <szaimen@e.mail.de>
@szaimen
Copy link
Contributor

szaimen commented Mar 8, 2022

samba failure unrelated

@szaimen szaimen merged commit 7f10de2 into stable23 Mar 8, 2022
@szaimen szaimen deleted the backport/28227/stable23 branch March 8, 2022 09:03
@blizzz blizzz mentioned this pull request Mar 9, 2022
@Jerome-Herbinet
Copy link
Member

My Nextcloud instance is in version 23.0.5 and I still have the problem ... dozens of notifications when videos are played through a public link (shared with an email).

@szaimen
Copy link
Contributor

szaimen commented May 29, 2022

Yes, notifications are not fixed with this...

Cc @nickvergessen on ideas how we can implement a fix for notifications, too

@nickvergessen
Copy link
Member

Opt out of getting notifications for this type of activities.
Other than that: nextcloud/files_downloadactivity#47

@Jerome-Herbinet
Copy link
Member

Jerome-Herbinet commented May 30, 2022

This might be an opportunity to distinguish between two actions, which would be visible in notifications (push and email) and activities: When someone plays the video (or sound file) or downloads the file. These are two different things.
So, depending on the context (and therefore on the link that was clicked) we would have :

john.doe@mydomain.com downloaded hello-world.mp4
john.doe@mydomain.com played hello-world.mp4

john.doe@mydomain.com downloaded sound.mp3
john.doe@mydomain.com played sound.mp3

Do you want me to open another issue ?

@szaimen
Copy link
Contributor

szaimen commented May 30, 2022

Opt out of getting notifications for this type of activities.
Other than that: nextcloud/files_downloadactivity#47

All right. Do you think it would be possible to get some kind of activity merging like it exists for the acticity stream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: activity and notification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants