Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occ user:add-app-password #31519

Merged
merged 3 commits into from
Mar 11, 2022
Merged

Conversation

nickvergessen
Copy link
Member

Steps

Create an app-password via all 3 methods and check the differences:

…n app password

Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 please fix the typo

Copy link
Contributor

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but then I thought the original implementation was fine too 😅

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen force-pushed the bugfix/noid/fix-occ-user-add-apppassword branch from 137b633 to 50ccf7e Compare March 10, 2022 14:52
@PVince81 PVince81 merged commit cec00df into master Mar 11, 2022
@PVince81 PVince81 deleted the bugfix/noid/fix-occ-user-add-apppassword branch March 11, 2022 10:55
@PVince81
Copy link
Member

/backport to stable23

@PVince81
Copy link
Member

/backport to stable22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants