Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not update _lastChanged on auto-detected attributes #31602

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Do not update _lastChanged on auto-detected attributes #31602

merged 2 commits into from
Mar 31, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Mar 17, 2022 •
edited
Loading

  • Does not work yet, because ldapConfigurationActive is always set and that count as a change.

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

@come-nc come-nc added the 2. developing Work in progress label Mar 17, 2022
@come-nc come-nc added this to the Nextcloud 24 milestone Mar 17, 2022
@come-nc come-nc self-assigned this Mar 17, 2022
@come-nc come-nc force-pushed the fix/user_ldap-fix-last-change-updates branch from 8c0ec1d to 2020cc7 Compare March 22, 2022 13:56
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 22, 2022
@come-nc come-nc requested review from a team, nickvergessen, ArtificialOwl, juliushaertl and blizzz and removed request for a team March 22, 2022 13:57
@skjnldsv skjnldsv mentioned this pull request Mar 24, 2022
Merged
@come-nc
Copy link
Contributor Author

come-nc commented Mar 29, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/user_ldap-fix-last-change-updates branch from 2020cc7 to 68808b1 Compare March 29, 2022 12:43
@blizzz blizzz mentioned this pull request Mar 31, 2022
Merged
@come-nc
Copy link
Contributor Author

come-nc commented Mar 31, 2022

/rebase

@come-nc
Do not update _lastChanged on auto-detected attributes
bd9c4fb 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Avoid updating _lastChange when nothing is changed in the configuration
9fc00fd 
Had to set at least one var when creating an empty configuration in
 order to save the default values.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/user_ldap-fix-last-change-updates branch from 68808b1 to 9fc00fd Compare March 31, 2022 08:38
PVince81
PVince81 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit d4c558a into master Mar 31, 2022
@PVince81 PVince81 deleted the fix/user_ldap-fix-last-change-updates branch March 31, 2022 12:07
@PVince81
Copy link
Member

24 only or bugfix for older versions already ? (I can't say as there was no context specified)

@come-nc
Copy link
Contributor Author

come-nc commented Apr 12, 2022

24 only or bugfix for older versions already ? (I can't say as there was no context specified)

I think it should be backported, just have to remove the property typing for 7.3 support.
Because I do not think the problem was 24 only.

@blizzz blizzz mentioned this pull request Apr 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@blizzz blizzz blizzz approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
3 participants
@come-nc @PVince81 @blizzz