Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] improve imagick, bcmath and gmp extension warnings #31634

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #31470

@szaimen
Copy link
Contributor

szaimen commented Mar 21, 2022

/rebase

@MichaIng
Copy link
Member

/rebase

@MichaIng
Copy link
Member

Drone failure is unrelated.

@szaimen
Copy link
Contributor

szaimen commented Mar 31, 2022

The autoloaders are not up to date
--
Please run: bash build/autoloaderchecker.sh
And commit the result

@MichaIng
Copy link
Member

@szaimen
Where can this annotation be found? I just see the expectedly failing Samba Drone test.

@szaimen
Copy link
Contributor

szaimen commented Mar 31, 2022

image

@MichaIng
Copy link
Member

MichaIng commented Apr 2, 2022

Okay, autoloaders updated. However, to me it looks like it is completely unrelated to this PR. But the (many) changes look good.

Strange is now that Node workflows fail due to package(-lock).json being out of sync. No idea how updating (PHP) autoloaders can affect the untouched Node dependencies 🤔.

@MichaIng
Copy link
Member

MichaIng commented Apr 2, 2022

Ah, indeed the Node failures are unrelated, some on all other recent stable23 base branch PRs, e.g.: #31788

I can try to fix it, but I think this should be better solved in a dedicated PR. I could also revert the autoloaders update and apply this in a separate PR.

@szaimen
Copy link
Contributor

szaimen commented Apr 4, 2022

I can try to fix it, but I think this should be better solved in a dedicated PR. I could also revert the autoloaders update and apply this in a separate PR.

sounds good to me, thanks!👍

@MichaIng
Copy link
Member

MichaIng commented Apr 4, 2022

sounds good to me, thanks!👍

Which of the 3 options? 😄
I think I'll just open new PRs to fix the unrelated issues, including the autoloader update.

@szaimen
Copy link
Contributor

szaimen commented Apr 4, 2022

I think I'll just open new PRs to fix the unrelated issues, including the autoloader update.

Yes, this one is what I meant. Sry! :)

@MichaIng
Copy link
Member

MichaIng commented Apr 6, 2022

@blizzz blizzz mentioned this pull request Apr 13, 2022
@blizzz blizzz added the 2. developing Work in progress label Apr 14, 2022
@blizzz
Copy link
Member

blizzz commented Apr 14, 2022

manual rebase is necessary

szaimen and others added 2 commits April 14, 2022 13:29
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
@MichaIng
Copy link
Member

Done

@MichaIng MichaIng added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 14, 2022
@blizzz
Copy link
Member

blizzz commented Apr 14, 2022

Drone CI was green (apart of Samba failing for other reasons)

@blizzz blizzz merged commit e5c6de3 into stable23 Apr 14, 2022
@blizzz blizzz deleted the backport/31470/stable23 branch April 14, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants