Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #31692 of occ files:scan #32059

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Fix issue #31692 of occ files:scan #32059

merged 1 commit into from
Jun 10, 2022

Conversation

cld4h
Copy link
Contributor

@cld4h cld4h commented Apr 22, 2022 •
edited by st3iny
Loading

occ files:scan reports error "Implicit conversion from float XXX to int loses precision"
@st3iny
@spicemint

fixes #31692

CarlSchwan
CarlSchwan approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@CarlSchwan CarlSchwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cld4h Please fix the DCO (https://github.com/nextcloud/server/pull/32059/checks?check_run_id=6122135498), but otherwise this looks good 👍

@CarlSchwan CarlSchwan requested a review from st3iny April 22, 2022 12:10
@st3iny st3iny added this to the Nextcloud 25 milestone Apr 22, 2022
st3iny
st3iny approved these changes Apr 22, 2022
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the fix.

@st3iny
Copy link
Member

st3iny commented Apr 22, 2022

/backport to stable24

@st3iny
Copy link
Member

st3iny commented Apr 22, 2022

Other backports are not necessary because this deprecation was introduced in PHP v8.1.

@cld4h
Fix issue nextcloud#31692 of occ files:scan
553239c 
occ files:scan reports error "Implicit conversion from float XXX to int loses precision"

Signed-off-by: cld4h <20869428+cld4h@users.noreply.github.com>
@cld4h
Copy link
Contributor Author

cld4h commented Apr 26, 2022

@CarlSchwan
@st3iny
Sorry for the late response.
Just figured out how to modify the previous commit and add a Sign-off line.

@st3iny
Copy link
Member

st3iny commented Apr 26, 2022

Looks good now. Drone failure seems to be unrelated.

@PVince81 PVince81 merged commit e6e1862 into nextcloud:master Jun 10, 2022
@welcome
Copy link

welcome bot commented Jun 10, 2022

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@st3iny st3iny mentioned this pull request Jun 12, 2022
Merged
@kesselb kesselb mentioned this pull request Jun 12, 2022
Merged
@st3iny st3iny mentioned this pull request Jan 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: occ
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.

occ files:scan reports error "Implicit conversion from float XXX to int loses precision"
5 participants
@cld4h @st3iny @CarlSchwan @PVince81 @skjnldsv