Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default fallback theme on setup any guests pages #32147

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Fix default fallback theme on setup any guests pages #32147

merged 1 commit into from
Apr 26, 2022

Conversation

skjnldsv
Copy link
Member

No description provided.

@skjnldsv
Fix default fallback theme on setup ang guests pages
6ec0dfe 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming regression labels Apr 26, 2022
@skjnldsv skjnldsv added this to the Nextcloud 25 milestone Apr 26, 2022
@skjnldsv skjnldsv requested review from nickvergessen and a team April 26, 2022 06:51
@skjnldsv skjnldsv self-assigned this Apr 26, 2022
@skjnldsv skjnldsv requested review from PVince81, artonge and vanpertsch and removed request for a team April 26, 2022 06:51
@skjnldsv skjnldsv mentioned this pull request Apr 26, 2022
Closed
46 tasks
@nickvergessen nickvergessen changed the title Fix default fallback theme on setup ang guests pages Fix default fallback theme on setup any guests pages Apr 26, 2022
szaimen
szaimen approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but did not test

nickvergessen
nickvergessen approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the integration test:

Scenario: setup page is shown properly # /drone/src/build/integration/setup_features/setup.feature:3

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 26, 2022
@skjnldsv skjnldsv merged commit 8a3f8b0 into master Apr 26, 2022
@skjnldsv skjnldsv deleted the fix/css-default-load-setup-guest branch April 26, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@artonge artonge Awaiting requested review from artonge

@vanpertsch vanpertsch Awaiting requested review from vanpertsch

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish design Design, UI, UX, etc. feature: theming regression
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @nickvergessen @CarlSchwan @szaimen