Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crop condition #32496

Merged
merged 1 commit into from
May 20, 2022
Merged

Fix crop condition #32496

merged 1 commit into from
May 20, 2022

Conversation

CarlSchwan
Copy link
Member

Make sure that when fetching the image from the cache we don't
accidentally fetch the cropped image just because it also start with
256-256

@CarlSchwan CarlSchwan added 3. to review Waiting for reviews regression labels May 19, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone May 19, 2022
@CarlSchwan CarlSchwan requested review from PVince81, skjnldsv and a team May 19, 2022 11:15
@CarlSchwan CarlSchwan self-assigned this May 19, 2022
@CarlSchwan CarlSchwan requested review from blizzz and removed request for a team May 19, 2022 11:15
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Make sure that when fetching the image from the cache we don't
accidentally fetch the cropped image just because it also start with
256-256

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@skjnldsv skjnldsv merged commit 818b898 into master May 20, 2022
@skjnldsv skjnldsv deleted the fix/cropp-condition branch May 20, 2022 06:08
@skjnldsv
Copy link
Member

Backport ?

@CarlSchwan
Copy link
Member Author

/backport to stable23

@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@CarlSchwan
Copy link
Member Author

/backport to stable24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants