-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct plural implementation for upload estimation #3251
Conversation
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @butonic, @luckydonald and @vincchan to be potential reviewers. |
This is fixed on master? |
Master uses completly different code it seems, at least I couldn't find the strings. |
@LukasReschke Old code is still present at transifex. |
Yes, because we combine stable10, stable11 and master. But maybe we should remove stable10 form the list now, as it should be translated quite well now. |
Ah, ok. Would you enlighten me on how to do this? Transifex magic? |
Not that much magic: https://github.com/nextcloud/docker-ci/blob/master/translations/handleTranslations.sh#L14-L36 We iterate over "stable10 stable11 master" and extract the l10n files, concatenate them with msgcat (which does de-duplication) and use this as resource for transifex. And the reverse works similar: fetch the translations and then play in the translation into stable10 stable11 and master git branches: https://github.com/nextcloud/docker-ci/blob/master/translations/handleTranslations.sh#L51-L53 |
Next night they will be gone nextcloud/docker-ci@87ab8c1 😉 |
Fix https://www.transifex.com/nextcloud/nextcloud/translate/#de/files/91001485
@MorrisJobke @LukasReschke