Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable24] Handle non existing settings again #32657

Merged
merged 2 commits into from
Jun 10, 2022
Merged

[stable24] Handle non existing settings again #32657

merged 2 commits into from
Jun 10, 2022

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #32655

@CarlSchwan @backportbot-nextcloud
Handle non existing settings again
616464b 
See #28189 (comment)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 24.0.2 milestone May 30, 2022
danxuliu
danxuliu approved these changes May 30, 2022
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@nickvergessen
Copy link
Member

This breaks sections/settings from apps

@nickvergessen
Fix unit tests
26050a4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
nickvergessen approved these changes May 31, 2022
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended a fix for the unit tests

@blizzz blizzz mentioned this pull request Jun 9, 2022
Merged
2 tasks
@PVince81 PVince81 merged commit ddac16b into stable24 Jun 10, 2022
@PVince81 PVince81 deleted the backport/32655/stable24 branch June 10, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danxuliu danxuliu danxuliu approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Nextcloud 24.0.2
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @danxuliu @PVince81 @CarlSchwan