Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

22.2.9 RC1 #32783

Merged
merged 1 commit into from
Jun 13, 2022
Merged

22.2.9 RC1 #32783

merged 1 commit into from
Jun 13, 2022

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jun 9, 2022

@blizzz blizzz added this to the Nextcloud 22.2.9 milestone Jun 9, 2022
@blizzz blizzz added the 3. to review Waiting for reviews label Jun 9, 2022
@kesselb
Copy link
Contributor

kesselb commented Jun 9, 2022

⚠️ Heads up!

AWS SDK update #29607 also updated Guzzle PSR7 to Version 2. While the server pr is not merged yet the 3rdparty pull request is and sneaked in with some other dependency update (if anyone of you know please let me know - I couldn't figure out which one).

Our version of azure-storage-common is not fully compatible yet with Guzzle PSR7 2 but an updated version is available: https://github.com/Azure/azure-storage-blob-php/releases/tag/v1.5.3

In addition tests/lib/Http/Client/ResponseTest.php needs a update because stream_for (dropped with Guzzle PSR7 2) is also gone.

cc @CarlSchwan

@st3iny
Copy link
Member

st3iny commented Jun 10, 2022

@kesselb @nickvergessen

I think I found it: #32652

It pulls an update of aws-sdk accidentally:

Submodule 3rdparty fd0d5d72f4..b9b7832960:
> Merge pull request #1044 from nextcloud/bump/symfony/translation-22
> Merge pull request #1005 from nextcloud/dependabot/composer/stable22/aws/aws-sdk-php-3.212.2
> Merge pull request #972 from nextcloud/backport/970/stable22                                            

@blizzz
Copy link
Member Author

blizzz commented Jun 10, 2022

@kesselb @nickvergessen

I think I found it: #32652

It pulls an update of aws-sdk accidentally:

Submodule 3rdparty fd0d5d72f4..b9b7832960:
> Merge pull request #1044 from nextcloud/bump/symfony/translation-22
> Merge pull request #1005 from nextcloud/dependabot/composer/stable22/aws/aws-sdk-php-3.212.2
> Merge pull request #972 from nextcloud/backport/970/stable22                                            

The 3rdparty PR is nextcloud/3rdparty#1044 which does not pull any other deps

@nickvergessen
Copy link
Member

It's actually nextcloud/3rdparty#1005

@nickvergessen
Copy link
Member

#29607 never was merged in server

@blizzz
Copy link
Member Author

blizzz commented Jun 13, 2022

/rebase

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz merged commit f2036e8 into stable22 Jun 13, 2022
@blizzz blizzz deleted the release/22.2.9_rc1 branch June 13, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants