Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined when no tags #32857

Merged
merged 1 commit into from
Jun 29, 2022
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jun 13, 2022

To reproduce:

Run tag:list without having any tags ;)

{
  "reqId": "lP0erYeSlc6i8SLp6fcp",
  "level": 3,
  "time": "2022-06-10T15:54:16+00:00",
  "remoteAddr": "",
  "user": "--",
  "app": "PHP",
  "method": "",
  "url": "--",
  "message": "Undefined variable: result at httpdocs/core/Command/SystemTag/ListCommand.php#82",
  "userAgent": "--",
  "version": "22.2.8.1",
  "exception": {
    "Exception": "Error",
    "Message": "Undefined variable: result at httpdocs/core/Command/SystemTag/ListCommand.php#82",
    "Code": 0,
    "Trace": [
      {
        "file": "httpdocs/core/Command/SystemTag/ListCommand.php",
        "line": 82,
        "function": "onError",
        "class": "OC\\Log\\ErrorHandler",
        "type": "::"
      },
      {
        "file": "httpdocs/core/Command/SystemTag/ListCommand.php",
        "line": 67,
        "function": "formatTags",
        "class": "OC\\Core\\Command\\SystemTag\\ListCommand",
        "type": "->"
      },
      {
        "file": "httpdocs/3rdparty/symfony/console/Command/Command.php",
        "line": 255,
        "function": "execute",
        "class": "OC\\Core\\Command\\SystemTag\\ListCommand",
        "type": "->"
      },
      {
        "file": "httpdocs/core/Command/Base.php",
        "line": 168,
        "function": "run",
        "class": "Symfony\\Component\\Console\\Command\\Command",
        "type": "->"
      },
      {
        "file": "httpdocs/3rdparty/symfony/console/Application.php",
        "line": 1009,
        "function": "run",
        "class": "OC\\Core\\Command\\Base",
        "type": "->"
      },
      {
        "file": "httpdocs/3rdparty/symfony/console/Application.php",
        "line": 273,
        "function": "doRunCommand",
        "class": "Symfony\\Component\\Console\\Application",
        "type": "->"
      },
      {
        "file": "httpdocs/3rdparty/symfony/console/Application.php",
        "line": 149,
        "function": "doRun",
        "class": "Symfony\\Component\\Console\\Application",
        "type": "->"
      },
      {
        "file": "httpdocs/lib/private/Console/Application.php",
        "line": 209,
        "function": "run",
        "class": "Symfony\\Component\\Console\\Application",
        "type": "->"
      },
      {
        "file": "httpdocs/console.php",
        "line": 99,
        "function": "run",
        "class": "OC\\Console\\Application",
        "type": "->"
      },
      {
        "file": "httpdocs/occ",
        "line": 11,
        "args": [
          "httpdocs/console.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "httpdocs/lib/private/Log/ErrorHandler.php",
    "Line": 92,
    "CustomMessage": "--"
  },
  "id": "62a6fa1003960"
}

@kesselb kesselb added bug 2. developing Work in progress labels Jun 13, 2022
@kesselb kesselb self-assigned this Jun 13, 2022
@kesselb kesselb added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 13, 2022
@kesselb kesselb requested review from a team, ArtificialOwl, icewind1991 and come-nc and removed request for a team June 13, 2022 14:54
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb force-pushed the debt/noid/result-may-undefined branch from e05443c to fb8d54e Compare June 28, 2022 13:44
@kesselb
Copy link
Contributor Author

kesselb commented Jun 29, 2022

/backport to stable24

@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 29, 2022
@CarlSchwan CarlSchwan merged commit 477dae9 into master Jun 29, 2022
@CarlSchwan CarlSchwan deleted the debt/noid/result-may-undefined branch June 29, 2022 13:11
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants