Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remake phone number property saving with Vue #33311

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jul 21, 2022

Remake phone number property saving with Vue for accessibility purposes

The https://github.com/catamphetamine/libphonenumber-js library is used here to mirror our backend validation https://github.com/giggsey/libphonenumber-for-php

if ($phoneNumber instanceof PhoneNumber && $phoneUtil->isValidNumber($phoneNumber)) {
as closely as possible

@github-actions
Copy link
Contributor

Possible performance regression detected

Show Output
1 queries added

= /remote.php/dav/files/test
≠ /remote.php/dav/files/test/test.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
≠ /remote.php/dav/files/test/many_files with 1 queries removed
  - UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)
= /remote.php/dav/files/test/new_file.txt
≠ /remote.php/dav/files/test/new_file.txt with 1 queries added
  + UPDATE "oc_preferences" SET "configvalue" = :dcValue1 WHERE ("userid" = :dcValue2) AND ("appid" = :dcValue3) AND ("configkey" = :dcValue4)

@Pytal Pytal force-pushed the enh/27869/twitter branch from 77f73f8 to 13ca063 Compare July 27, 2022 00:19
@Pytal Pytal force-pushed the enh/27869/phone branch from 84abf2c to 347407d Compare July 27, 2022 00:28
@Pytal Pytal force-pushed the enh/27869/twitter branch from 13ca063 to 91fc449 Compare July 27, 2022 00:53
@Pytal Pytal force-pushed the enh/27869/phone branch 2 times, most recently from 7900b6a to d468f61 Compare July 28, 2022 01:08
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 28, 2022
@Pytal Pytal force-pushed the enh/27869/twitter branch 6 times, most recently from 7e0cd45 to 7fd6634 Compare July 29, 2022 20:16
@Pytal Pytal force-pushed the enh/27869/phone branch from d468f61 to bf664a3 Compare July 29, 2022 20:30
@Pytal Pytal force-pushed the enh/27869/twitter branch from 7fd6634 to df757f3 Compare August 9, 2022 03:09
@Pytal Pytal force-pushed the enh/27869/phone branch from bf664a3 to fa68db1 Compare August 9, 2022 03:19
@Pytal Pytal force-pushed the enh/27869/twitter branch from df757f3 to 257ab46 Compare August 11, 2022 02:12
This was referenced Aug 12, 2022
@blizzz blizzz mentioned this pull request Aug 24, 2022
@Pytal Pytal force-pushed the enh/27869/twitter branch from 257ab46 to 09f6eb5 Compare August 25, 2022 18:19
Base automatically changed from enh/27869/twitter to master August 25, 2022 21:40
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal marked this pull request as ready for review August 27, 2022 00:30
@Pytal Pytal requested a review from CarlSchwan as a code owner August 27, 2022 00:30
@Pytal Pytal requested review from a team, PVince81, skjnldsv and szaimen and removed request for a team August 27, 2022 00:30
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit d7deeb4 into master Aug 29, 2022
@PVince81 PVince81 deleted the enh/27869/phone branch August 29, 2022 12:53
@blizzz blizzz mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants