-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remake phone number property saving with Vue #33311
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
enhancement
2. developing
Work in progress
feature: settings
feature: accessibility
accessibility
labels
Jul 21, 2022
11 tasks
Possible performance regression detected Show Output
|
Pytal
force-pushed
the
enh/27869/phone
branch
2 times, most recently
from
July 28, 2022 01:08
7900b6a
to
d468f61
Compare
Pytal
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jul 28, 2022
Pytal
force-pushed
the
enh/27869/twitter
branch
6 times, most recently
from
July 29, 2022 20:16
7e0cd45
to
7fd6634
Compare
Pytal
force-pushed
the
enh/27869/twitter
branch
from
August 9, 2022 03:09
7fd6634
to
df757f3
Compare
Pytal
force-pushed
the
enh/27869/twitter
branch
from
August 11, 2022 02:12
df757f3
to
257ab46
Compare
Merged
Pytal
force-pushed
the
enh/27869/twitter
branch
from
August 25, 2022 18:19
257ab46
to
09f6eb5
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
requested review from
a team,
PVince81,
skjnldsv and
szaimen
and removed request for
a team
August 27, 2022 00:30
skjnldsv
approved these changes
Aug 28, 2022
PVince81
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remake phone number property saving with Vue for accessibility purposes
The https://github.com/catamphetamine/libphonenumber-js library is used here to mirror our backend validation https://github.com/giggsey/libphonenumber-for-php
server/lib/private/Accounts/AccountManager.php
Line 188 in 952acd4