Document pitfalls when building production assets #33322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise building assets for production will fail CI due to differences. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
changed the title
PVince81
added
3. to review
PVince81
requested review from
nickvergessen,
Pytal,
skjnldsv,
artonge and
CarlSchwan
| @@ -14,6 +14,9 @@ build-js: | |||
| npm run dev | |||
|
|
|||
| build-js-production: | |||
| @echo Using node version $(shell node -v) and npm version $(shell npm -v) | |||
| @echo Please make sure you are using the same version as recommended in the README.md | |||
There was a problem hiding this comment.
Can we instead read the environment from package.json?
Could even compare it and fail the make step
There was a problem hiding this comment.
I thought of this but this was from the time I believed that my asset problem was related to node versions, but it wasn't, it was about the additional apps I didn't move to apps-extra, so not sure if we should be hard about node versions
Merged
PVince81
added
2. developing
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise building assets for production will fail CI due to
differences.
Because it's super annoying to get CI fails despite having been nice enough to run
make build-js-production(example: #33321)