Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port password settings to vue #33429

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Port password settings to vue #33429

merged 1 commit into from
Aug 31, 2022

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Aug 2, 2022 •
edited
Loading

  • Port to vue
  • Update nextcloud vue component to latest beta to use ncpasswordfield component
  • Update the visual look
    image

@CarlSchwan CarlSchwan added the 2. developing Work in progress label Aug 2, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Aug 2, 2022
@CarlSchwan CarlSchwan self-assigned this Aug 2, 2022
jancborchardt
jancborchardt approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice design-wise! :)

cc @marcoambrosini since you worked on the TextInput – are you good with how it looks together with the button?

marcoambrosini
marcoambrosini approved these changes Aug 2, 2022
View reviewed changes
Copy link
Member

@marcoambrosini marcoambrosini left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm too, but shouldn't we wait for the input component and use that @CarlSchwan?

This was referenced Aug 12, 2022
Merged
Merged
@blizzz blizzz mentioned this pull request Aug 24, 2022
Merged
@CarlSchwan
Copy link
Member Author

NcPasswordField is now merged, just need a new release of the nextcloud vue library ;)

@blizzz blizzz mentioned this pull request Aug 30, 2022
Merged
@CarlSchwan CarlSchwan changed the title WIP: Port password settings to vue Port password settings to vue Aug 31, 2022
@CarlSchwan CarlSchwan force-pushed the port-password-vue branch 2 times, most recently from 58baee9 to 8b79cdd Compare August 31, 2022 11:02
@CarlSchwan CarlSchwan added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Aug 31, 2022
@CarlSchwan CarlSchwan force-pushed the port-password-vue branch 2 times, most recently from 84c369f to e8a94af Compare August 31, 2022 13:10
@CarlSchwan
Port password settings to vue
60c4291 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
Copy link
Member Author

Ci failures unrelated

@CarlSchwan CarlSchwan merged commit 9689f73 into master Aug 31, 2022
@CarlSchwan CarlSchwan deleted the port-password-vue branch August 31, 2022 18:47
@CarlSchwan CarlSchwan mentioned this pull request Sep 1, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@jancborchardt jancborchardt jancborchardt approved these changes

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees

@CarlSchwan CarlSchwan

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 25
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlSchwan @jancborchardt @marcoambrosini