Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/358 add missing expanded attributes #33522

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Aug 12, 2022

No description provided.

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/358-add-missing-expanded-attributes branch from 90dc5fc to d5dd1fe Compare August 15, 2022 08:41
@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review August 15, 2022 08:46
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Aug 15, 2022
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Aug 15, 2022
@nickvergessen nickvergessen added this to the Nextcloud 25 milestone Aug 15, 2022
apps/files/js/fileactions.js Outdated Show resolved Hide resolved
apps/theming/js/3rdparty/jscolor/jscolor.js Show resolved Hide resolved
webpack.common.js Outdated Show resolved Hide resolved
@PVince81 PVince81 requested a review from skjnldsv August 15, 2022 09:30
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐘

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/358-add-missing-expanded-attributes branch from 0458a7b to d5173eb Compare August 17, 2022 12:32
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 17, 2022
@skjnldsv

This comment was marked as resolved.

@nextcloud-command nextcloud-command force-pushed the fix/358-add-missing-expanded-attributes branch from d5173eb to ea749cb Compare August 17, 2022 19:20
@skjnldsv
Copy link
Member

/compile amend /

…ile tags

Add ```aria-expanded``` to color picker
Add ```aria-expanded``` to UnifiedSearch.vue
Add ```aria-expanded``` to new button on files
Add ```aria-expanded``` to action menu
Add ```aria-expanded``` to icon .federation-menu
Add ```aria-expanded``` to app navigation collapse button

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/358-add-missing-expanded-attributes branch from ea749cb to 6d12f8b Compare August 17, 2022 19:28
@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
@JuliaKirschenheuter JuliaKirschenheuter merged commit 1463f93 into master Aug 19, 2022
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/358-add-missing-expanded-attributes branch August 19, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants