Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use LazyUser in DefaultShareProvider #33581

Merged
merged 2 commits into from
Jun 17, 2024
Merged

use LazyUser in DefaultShareProvider #33581

merged 2 commits into from
Jun 17, 2024

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 17, 2022
@icewind1991 icewind1991 added this to the Nextcloud 25 milestone Aug 17, 2022
@icewind1991 icewind1991 requested review from a team, PVince81, ArtificialOwl and come-nc and removed request for a team August 17, 2022 12:30
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
@nickvergessen
Copy link
Member

Tests: 4297, Assertions: 15882, Failures: 11, Skipped: 28, Risky: 1.

DB unit tests are failing

@PVince81
Copy link
Member

@icewind1991 please fix the tests

This was referenced Aug 24, 2022
This was referenced Sep 6, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
@PVince81 PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 16, 2022
This was referenced Sep 20, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz mentioned this pull request Feb 1, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz added this to the Nextcloud 27 milestone Mar 9, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 17, 2023

@icewind1991 can you please fix the tests?

This was referenced May 3, 2023
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
Signed-off-by: Robin Appelman <robin@icewind.nl>
@come-nc
Copy link
Contributor

come-nc commented Jun 17, 2024

Rebased and fixed conflicts

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@blizzz blizzz merged commit 2bc949d into master Jun 17, 2024
163 of 164 checks passed
@blizzz blizzz deleted the share-lazy-user branch June 17, 2024 20:53
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants