Added parameter to disable "Add to your nextcloud" option in public shares

[pboguslawski]

Added app files_sharing parameter showExternalShareOption to allow one to hide
"Add to your nextcloud" option in public shares (shown by default). Use

occ config:app:set files_sharing showExternalShareOption --value='no'

to hide and

occ config:app:set files_sharing showExternalShareOption --value='yes'

to restore.

Related: #12395
Author-Change-Id: IB#1123210
Signed-off-by: Pawel Boguslawski pawel.boguslawski@ib.pl

[jancborchardt]

@PVince81 @schiessle should this not simply be linked to the Federated Sharing options? When federated sharing is disabled, this should not be shown.

[schiessle]

Yes, I would also expect that we hide it if outgoing federated shares are disabled on the server

[jancborchardt]

@pboguslawski could you adjust your pull request so that the behavior is simply linked to the existing setting and doesn’t need another option? Thank you! :)

[pboguslawski]

According to

https://docs.nextcloud.com/server/latest/user_manual/th/files/sharing.html#adding-a-public-share-to-your-nextcloud

Add to your nextcloud option allows one to add also external nc directories into local nc account; disabling local nc federation should probably be independent of dissallowing users to link to external nc directories, thats why separate param in this PR.

Disabling local nc federation may also disable adding external directories but this should be considered as separate PR if required.

If you still doesn't see point in separate param - please suggest existing parameter that should be used.

[jancborchardt]

@schiessle what is the technical name of the existing param that should be used? I'd still say that yes, it should be the same setting.

[jeayalar]

Added app files_sharing parameter showExternalShareOption to allow one to hide "Add to your nextcloud" option in public shares (shown by default). Use

occ config:app:set files_sharing showExternalShareOption --value='no'

to hide and

occ config:app:set files_sharing showExternalShareOption --value='yes'

to restore.

Related: #12395 Author-Change-Id: IB#1123210 Signed-off-by: Pawel Boguslawski pawel.boguslawski@ib.pl

The occ command previously shared to hide the "Add to your nextcloud" option, does not seem to work in NC 27.1.4. At least I couldn't manage to hide it using:

occ config:app:set files_sharing showExternalShareOption --value='no'

[jancborchardt]

@AndyScherzinger this needs input/assessment from an engineer familiar with the matter. I gave my design feedback above. :)

[AndyScherzinger]

@sorbaugh is back, so rather let him handle it than me 😃 🙏

[skjnldsv]

Add to your nextcloud option allows one to add also external nc directories into local nc account; disabling local nc federation should probably be independent of dissallowing users to link to external nc directories, thats why separate param in this PR.

Disabling local nc federation may also disable adding external directories but this should be considered as separate PR if required.

I understand the point, I'd say considering those options are pretty related, and for the sake of user experience and simplicity, we should keep the same setting :)

Do you mind rebasing your PR and using the isOutgoingServer2serverShareEnabled method?

[pboguslawski]

Do you mind rebasing your PR and using the isOutgoingServer2serverShareEnabled method?

Isn't files_sharing.outgoing_server2server_share_enabled = yes required for public webdav shares to work? Disallowing external shares mounting locally should not block using public webdav in opposite direction so using isOutgoingServer2serverShareEnabled method is not good solution here.

[skjnldsv]

Do you mind rebasing your PR and using the isOutgoingServer2serverShareEnabled method?

Isn't files_sharing.outgoing_server2server_share_enabled = yes required for public webdav shares to work? Disallowing external shares mounting locally should not block using public webdav in opposite direction so using isOutgoingServer2serverShareEnabled method is not good solution here.

Not anymore!
We should edit the setting label btw. Since nc 28, you can disable federated sharing but still have link shares.

So this issue is now resolved 🎉
Thank you nonetheless for the PR @pboguslawski, that was an interesting discussion and I'm glad it's solved now