Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated at matcher in tests/lib part 2 #33732

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Aug 29, 2022

Follow up of #32901

Signed-off-by: Côme Chilliet come.chilliet@nextcloud.com

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 2. developing Work in progress label Aug 29, 2022
@come-nc come-nc self-assigned this Aug 29, 2022
@come-nc come-nc added this to the Nextcloud 25 milestone Aug 29, 2022
Only 15 warnings left in there

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
Copy link
Contributor Author

come-nc commented Aug 29, 2022

There are still at matcher in 2 files:

  • tests/lib/AppFramework/Db/MapperTestUtility.php -> This is complex code that uses at() with growing indices to have generic code. I suppose the stored index need to be replaced by stored arrays with the parameters and return values expected and pass them to withConsecutive/willReturnOnConsecutiveCalls in the end.
  • tests/lib/Mail/MailerTest.php -> only at(1) is used so it’s unclear to me how to migrate this.

@CarlSchwan
Copy link
Member

There are still at matcher in 2 files:

* tests/lib/AppFramework/Db/MapperTestUtility.php -> This is complex code that uses at() with growing indices to have generic code. I suppose the stored index need to be replaced by stored arrays with the parameters and return values expected and pass them to withConsecutive/willReturnOnConsecutiveCalls in the end.

* tests/lib/Mail/MailerTest.php -> only at(1) is used so it’s unclear to me how to migrate this.

Let's do then in another PR then and merge this PR quickly

@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 30, 2022
@come-nc come-nc requested review from a team, PVince81, blizzz and skjnldsv and removed request for a team August 30, 2022 09:36
@come-nc come-nc marked this pull request as ready for review August 30, 2022 09:36
@skjnldsv skjnldsv merged commit efb6411 into master Aug 30, 2022
@skjnldsv skjnldsv deleted the fix/remove-at-matcher-in-lib-tests-2 branch August 30, 2022 09:50
@blizzz blizzz mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants