Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Wait for the new user form to be visible in acceptance tests #33792

Conversation

danxuliu
Copy link
Member

@danxuliu danxuliu commented Sep 1, 2022

Extracted from #33568

This should make the acceptance tests more robust and avoid failures like https://drone.nextcloud.com/nextcloud/server/21674/63/4

It only touches an acceptance test file, so it should not affect the RC (but fine to merge it after v23.0.9 too).

Before it was checked if the new user form was visible, but it was not waited for it. It seems that it can happen that the new user form is in the DOM, and therefore found, but not visible yet when the tests run, which caused them to (randomly) fail. Due to that now it is explicitly waited until it is visible, rather than assuming that it is visible as soon as it appears in the DOM.

Before it was checked if the new user form was visible, but it was not
waited for it. It seems that it can happen that the new user form is in
the DOM, and therefore found, but not visible yet when the tests run,
which caused them to (randomly) fail. Due to that now it is explicitly
waited until it is visible, rather than assuming that it is visible as
soon as it appears in the DOM.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@danxuliu danxuliu added the 3. to review Waiting for reviews label Sep 1, 2022
@danxuliu danxuliu added this to the Nextcloud 23.0.9 milestone Sep 1, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blizzz blizzz mentioned this pull request Sep 27, 2022
@blizzz blizzz merged commit 2cd11e2 into stable23 Sep 27, 2022
@blizzz blizzz deleted the backport/stable23-wait-for-the-new-user-form-to-be-visible-in-acceptance-tests branch September 27, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants