Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve app settings design #33900

Merged
merged 1 commit into from
Sep 6, 2022
Merged

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Sep 5, 2022

Close #33802

This is best reviewed like this: https://github.com/nextcloud/server/pull/33900/files?diff=unified&w=1

Before After
image image

Signed-off-by: szaimen szaimen@e.mail.de

@szaimen szaimen added the 2. developing Work in progress label Sep 5, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 5, 2022
@szaimen szaimen force-pushed the enh/33802/improve-appsettings-design branch from 80c296c to 5696eaa Compare September 5, 2022 13:23
@szaimen szaimen added 3. to review Waiting for reviews ui-refresh-feedback and removed 2. developing Work in progress labels Sep 5, 2022
@szaimen szaimen marked this pull request as ready for review September 5, 2022 13:33
@blizzz blizzz mentioned this pull request Sep 6, 2022
@jancborchardt
Copy link
Member

@szaimen do you have a before/after screenshot of the settings when they are collapsed? (Ideally should look the same). Regarding my concern at #33802 (comment)
I tried to test on my local instance but for some reason the area is not updated.

@szaimen
Copy link
Contributor Author

szaimen commented Sep 6, 2022

I tried to test on my local instance but for some reason the area is not updated.

I gues it is because the scss is not compiled yet...

@szaimen
Copy link
Contributor Author

szaimen commented Sep 6, 2022

/rebase

@nextcloud-command nextcloud-command force-pushed the enh/33802/improve-appsettings-design branch from 5696eaa to 0074ce1 Compare September 6, 2022 17:20
@szaimen
Copy link
Contributor Author

szaimen commented Sep 6, 2022

/compile amend /

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 6, 2022
Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/33802/improve-appsettings-design branch from 0074ce1 to 6579b6c Compare September 6, 2022 17:27
@szaimen
Copy link
Contributor Author

szaimen commented Sep 6, 2022

I tried to test on my local instance but for some reason the area is not updated.

I gues it is because the scss is not compiled yet...

should work now

@szaimen
Copy link
Contributor Author

szaimen commented Sep 6, 2022

LGTM:

closed opened
image image

@szaimen szaimen enabled auto-merge September 6, 2022 17:31
@szaimen
Copy link
Contributor Author

szaimen commented Sep 6, 2022

failing test unrelated

@szaimen szaimen disabled auto-merge September 6, 2022 17:59
@szaimen szaimen merged commit 2a59d48 into master Sep 6, 2022
@szaimen szaimen deleted the enh/33802/improve-appsettings-design branch September 6, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish ui-refresh-feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings panel in sidebar, separation a bit too weak visually
4 participants