Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix add user dialog #33977

Closed
wants to merge 3 commits into from
Closed

Fix add user dialog #33977

wants to merge 3 commits into from

Conversation

CarlSchwan
Copy link
Member

@CarlSchwan CarlSchwan commented Sep 8, 2022 •
edited
Loading

  • Add label instead of placeholder for accessibility
  • Port to new vue components

@CarlSchwan CarlSchwan marked this pull request as draft September 8, 2022 13:50
@CarlSchwan CarlSchwan linked an issue Sep 8, 2022 that may be closed by this pull request
[Bug]: NC 25 New User from missing better visible background shadow or outline #33951
Closed
9 tasks
@szaimen
Copy link
Contributor

szaimen commented Sep 8, 2022

the multiselect looks strange but I guess it will be improved with the next beta release of vue 7.0, correct?

@Pytal
Copy link
Member

Pytal commented Sep 13, 2022

Let's get this in after #34044

@CarlSchwan CarlSchwan self-assigned this Sep 15, 2022
@CarlSchwan CarlSchwan added this to the Nextcloud 25 milestone Sep 15, 2022
@skjnldsv skjnldsv mentioned this pull request Sep 15, 2022
Merged
@CarlSchwan
Fix add user dialog
103ba53 
- Add label instead of placeholder for accessibility
- Port to new vue components

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan marked this pull request as ready for review September 15, 2022 14:22
@CarlSchwan CarlSchwan requested review from a team, PVince81, Pytal and szaimen and removed request for a team September 15, 2022 14:22
Pytal
Pytal approved these changes Sep 15, 2022
View reviewed changes
apps/settings/src/components/UserList.vue Outdated Show resolved Hide resolved
apps/settings/src/components/UserList.vue Outdated Show resolved Hide resolved
apps/settings/src/components/UserList.vue Outdated Show resolved Hide resolved
apps/settings/src/components/UserList.vue Outdated Show resolved Hide resolved
@CarlSchwan @Pytal
simplify html code a bit
89d069e 
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
Copy link
Member Author

/compile amend /

@CarlSchwan @Pytal @nextcloud-command
simplify code a bit more
7619ca2 
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@CarlSchwan CarlSchwan requested a review from skjnldsv September 16, 2022 09:12
@PVince81
Copy link
Member

  • BUG: dialog doesn't close after creating a user, it just empties itself (same with an without the admin password prompt)

@PVince81 PVince81 added the 2. developing Work in progress label Sep 16, 2022
@szaimen
Copy link
Contributor

szaimen commented Sep 17, 2022

  • BUG: dialog doesn't close after creating a user, it just empties itself (same with an without the admin password prompt)

Maybe something wrong with resetting the focus or something?

Also, can we remove the custom multiselect styling and check if it improves the look?

This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@szaimen
Copy link
Contributor

szaimen commented Oct 20, 2022

@CarlSchwan what is missing here?

@PVince81 PVince81 assigned Pytal and unassigned CarlSchwan Dec 16, 2022
@PVince81
Copy link
Member

@Pytal please take over when the time is right as it touches accessibility

@szaimen
Copy link
Contributor

szaimen commented Dec 17, 2022

Now that we updated nextcloud/vue miltiple times in the meantime, maybe even a rebase already makes it work...

@szaimen szaimen mentioned this pull request Dec 27, 2022
Closed
@szaimen
Copy link
Contributor

szaimen commented Dec 27, 2022

I rebase this and pushed the changes to #35898

@szaimen szaimen closed this Dec 27, 2022
@szaimen szaimen deleted the fix/add-user-modal branch December 27, 2022 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@szaimen szaimen Awaiting requested review from szaimen

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@Pytal Pytal

Labels
2. developing Work in progress accessibility
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

[Bug]: NC 25 New User from missing better visible background shadow or outline
5 participants
@CarlSchwan @szaimen @Pytal @PVince81 @blizzz