Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle cases where SharedStorage::init isn't initializing the storage #33985

Closed
wants to merge 3 commits into from
Closed

handle cases where SharedStorage::init isn't initializing the storage #33985

wants to merge 3 commits into from

Conversation

icewind1991
Copy link
Member

Signed-off-by: Robin Appelman robin@icewind.nl

@icewind1991 icewind1991 added the 2. developing Work in progress label Sep 8, 2022
@icewind1991 icewind1991 force-pushed the share-null-source branch 2 times, most recently from f257fa5 to 53de49b Compare September 16, 2022 13:17
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 16, 2022
@icewind1991 icewind1991 requested review from a team, PVince81, skjnldsv and CarlSchwan and removed request for a team September 16, 2022 17:49
@PVince81
Copy link
Member

weird:

1) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testAddUserAlreadyExisting
Failed asserting that exception of type "Error" matches expected exception "OCP\AppFramework\OCS\OCSException". Message was: "Call to a member function t() on null" at
/drone/src/apps/provisioning_api/lib/Controller/UsersController.php:353
/drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:271
.

@PVince81 PVince81 requested a review from Pytal September 19, 2022 12:51
@PVince81 PVince81 added this to the Nextcloud 25 milestone Sep 19, 2022
@PVince81
Copy link
Member

/rebase

@blizzz blizzz mentioned this pull request Sep 19, 2022
Merged
@icewind1991 @PVince81
handle cases where SharedStorage::init isn't initializing the storage
21f09ad 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @PVince81
also set nonMaskedStorage when shared setup fails
0f617e7 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 @PVince81
switch to new logger interface
d20b53b 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@Pytal
Copy link
Member

Pytal commented Sep 19, 2022 

1) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testAddUserAlreadyExisting
Failed asserting that exception of type "Error" matches expected exception "OCP\AppFramework\OCS\OCSException". Message was: "Call to a member function t() on null" at
/drone/src/apps/provisioning_api/lib/Controller/UsersController.php:353
/drone/src/apps/provisioning_api/tests/Controller/UsersControllerTest.php:271
.

Fixed on master in 4de19e9

Pytal
Pytal reviewed Sep 19, 2022
View reviewed changes
apps/files_sharing/lib/SharedStorage.php
@@ -532,6 +548,17 @@ public function getSourceStorage() {

public function getWrapperStorage() {
$this->init();

// `init` should handle this, but apparently it sometimes doesn't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the reason for why it doesn't known?

This was referenced Sep 20, 2022
Closed
Merged
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@PVince81
Copy link
Member

@icewind1991 is this still valid or did we fix this in a different way ? possibly through #35218

This was referenced May 9, 2023
Closed
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 27, Nextcloud 28 May 9, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
Merged
Merged
Merged
This was referenced Mar 20, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
Merged
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv added 2. developing Work in progress stale Ticket or PR with no recent activity and removed 3. to review Waiting for reviews labels Jul 27, 2024
This was referenced Jul 30, 2024
Merged
Merged
This was referenced Aug 5, 2024
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@skjnldsv skjnldsv closed this Aug 14, 2024
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@skjnldsv skjnldsv deleted the share-null-source branch August 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal left review comments

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@CarlSchwan CarlSchwan Awaiting requested review from CarlSchwan

Assignees
No one assigned
Labels
2. developing Work in progress feature: sharing stale Ticket or PR with no recent activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@icewind1991 @PVince81 @Pytal @blizzz @skjnldsv