use HSTS when doing request with the HttpClient #34553
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
added
2. developing
CarlSchwan
reviewed
Oct 12, 2022
|
|
||
| $expires = $this->timeFactory->getTime() + $maxAge; | ||
|
|
||
| $qb = $this->db->getQueryBuilder(); |
There was a problem hiding this comment.
could we maybe make hosts unique and if we get an unique exeption when trying to insert then we try updating. Save one DB query in some cases
Also we probably should try to catch data races
There was a problem hiding this comment.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @param array $options | ||
| * @return null|ISchemaWrapper | ||
| */ | ||
| public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { |
Check failure
Code scanning / Psalm
MoreSpecificImplementedParamType
|
|
||
| if ($data !== false | ||
| && $this->timeFactory->getTime() < $data['expires'] | ||
| && (!$includeSubdomain || ($includeSubdomain && $data['includeSubdomains'])) |
Check failure
Code scanning / Psalm
RedundantCondition
|
|
||
| $request = $this->handleHSTSRewrite($request); | ||
|
|
||
| $this->logger->warning("GONNA REQUEST"); |
|
|
||
| return $handler($request, $options) | ||
| ->then(function (ResponseInterface $response) use ($request) { | ||
| $this->logger->error("GOT RESPONSE"); |
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
This was referenced Mar 14, 2024
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time to ensure that if a server we talk to supports HSTS we actually store this info and use it.
Help and commits to this branch are appreciated.
TODO
Future work: