Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check share attributes on preview endpoints #34788

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Check share attributes on preview endpoints #34788

merged 1 commit into from
Oct 26, 2022

Conversation

juliusknorr
Copy link
Member

Signed-off-by: Julius Härtl jus@bitgrid.net

@juliusknorr juliusknorr requested review from PVince81, CarlSchwan, a team and skjnldsv and removed request for a team October 25, 2022 07:16
PVince81
PVince81 approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Oct 25, 2022
@PVince81 PVince81 added this to the Nextcloud 26 milestone Oct 25, 2022
@PVince81
Copy link
Member

/backport to stable25

@PVince81
Copy link
Member

/backport to stable24

@PVince81
Copy link
Member

test failures are related:

1) Tests\Core\Controller\PreviewControllerTest::testNoPreview
Error: Call to a member function instanceOfStorage() on null

/drone/src/core/Controller/PreviewController.php:134
/drone/src/core/Controller/PreviewController.php:84
/drone/src/tests/Core/Controller/PreviewControllerTest.php:190

2) Tests\Core\Controller\PreviewControllerTest::testValidPreview
Error: Call to a member function instanceOfStorage() on null

/drone/src/core/Controller/PreviewController.php:134
/drone/src/core/Controller/PreviewController.php:84
/drone/src/tests/Core/Controller/PreviewControllerTest.php:223

@juliushaertl can you have a look ?

@PVince81 PVince81 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 25, 2022
@juliusknorr
Check share attributes on preview endpoints
8629d8e 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Oct 25, 2022
@juliusknorr
Copy link
Member Author

Failure seems unrelated, but restarted because I haven't seen that specific acceptance test failure yet on CI.

@juliusknorr juliusknorr merged commit aec8dce into master Oct 26, 2022
@juliusknorr juliusknorr deleted the bugfix/noid/preview-attributes branch October 26, 2022 13:11
This was referenced Oct 26, 2022
Merged
Merged
@szaimen szaimen mentioned this pull request Nov 23, 2022
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@PVince81 PVince81 PVince81 approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusknorr @PVince81 @CarlSchwan @come-nc