fix call to deprecated circles api #35030
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
/backport to stable25 |
|
/backport to stable24 |
|
/backport to stable23 |
szaimen
requested review from
a team,
blizzz and
juliusknorr
and removed request for
a team
juliusknorr
reviewed
Nov 9, 2022
juliusknorr
reviewed
Nov 9, 2022
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/deprecated-circles-api
branch
from
8298f50 to
1d09083
Compare
|
rebased |
| } | ||
| // checking if user is within said circle | ||
| // deprecated API, needs to be edited when ICirclesManager is implemented | ||
| \OCA\Circles\Api\v1\Circles::getMember($sharedWith, $userId, 1); |
Check notice
Code scanning / Psalm
UndefinedClass
There was a problem hiding this comment.
Can you add a stub for that in build/stubs and psalm.xml ? :)
Merged
Merged
Merged
come-nc
requested changes
Mar 21, 2023
| return false; | ||
| } catch (QueryException $e) { | ||
| } catch (\Exception $e) { | ||
| \OC::$server->getLogger()->logException($e); |
There was a problem hiding this comment.
Suggested change
| \OC::$server->getLogger()->logException($e); | |
| \OC::$server->get(LoggerInterface::class)->error($e->getMessage(), ['exception' => $e, 'app' => 'files_sharing']); |
This was referenced May 3, 2023
Merged
Closed
Merged
15 tasks
Merged
Merged
|
As there is no feedback since a while I will close this ticket. If this is still happening please make sure to upgrade to the latest version. After that, feel free to rebase & reopen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the current API to getMember() is deactivated and throws Exception by default.
A patch is in progress in Circles to return something if it exists, and throw exception if not.