recover deleted circles shares #35526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -159,6 +159,11 @@ | |||
| $result = array_merge($result, $this->getDeckShareHelper()->formatShare($share)); | |||
| } catch (QueryException $e) { | |||
| } | |||
| } elseif ($share->getShareType() === IShare::TYPE_CIRCLE) { | |||
| try { | |||
| $result = array_merge($result, $this->getCirclesShareHelper()->formatShare($share)); | |||
Check failure
Code scanning / Psalm
UndefinedDocblockClass
| * If the Circles application is not enabled or the helper is not available | ||
| * a QueryException is thrown instead. | ||
| * | ||
| * @return \OCA\Circles\ShareAPIHelper |
Check failure
Code scanning / Psalm
UndefinedDocblockClass
| */ | ||
| private function getCirclesShareHelper() { | ||
| if (!$this->appManager->isEnabledForUser('circles')) { | ||
| throw new QueryException(); |
Check notice
Code scanning / Psalm
DeprecatedClass Note
ArtificialOwl
force-pushed
the
fix/noid/deleted-circles-share
branch
from
594baac
to
bdee2be
Compare
Merged
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwl
force-pushed
the
fix/noid/deleted-circles-share
branch
from
bdee2be
to
76db2b0
Compare
Merged
ArtificialOwl
added
3. to review
|
/backport to stable27 |
|
/backport to stable26 |
susnux
requested review from
juliushaertl,
a team,
icewind1991 and
Fenn-CS
and removed request for
a team
come-nc
reviewed
Nov 9, 2023
| throw new QueryException(); | ||
| } | ||
|
|
||
| return $this->serverContainer->get('\OCA\Circles\ShareByCircleProvider'); |
There was a problem hiding this comment.
Why not \OCA\Circles\ShareAPIHelper ?
skjnldsv
added
2. developing
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to nextcloud/circles#1223 to list and recover deleted shares done to Circles