Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DESIGN.md to expected files #35855

Merged
merged 1 commit into from
Dec 22, 2022
Merged

Add DESIGN.md to expected files #35855

merged 1 commit into from
Dec 22, 2022

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Dec 21, 2022 •
edited
Loading

  • Resolves: /

Summary

Follow-up for #35656

TODO

  • Check Checkers ;)
  • Decide if DESIGN.md should be shipped with the release.

DESIGN.md should be shipped with the release:

DESIGN.md should not be shipped with the release:

  • Inform the release team to remove DESIGN.md

Checklist

@kesselb
Add DESIGN.md to expected files
b22e307 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb requested review from PVince81 and szaimen December 21, 2022 17:21
@kesselb kesselb added 3. to review Waiting for reviews technical debt labels Dec 21, 2022
@kesselb kesselb added this to the Nextcloud 26 milestone Dec 21, 2022
@szaimen szaimen requested review from skjnldsv and rubo77 December 21, 2022 17:23
@juliusknorr juliusknorr mentioned this pull request Dec 21, 2022
Merged
4 tasks
@szaimen szaimen merged commit d607047 into master Dec 22, 2022
@szaimen szaimen deleted the debt/noid/hello-design-md branch December 22, 2022 08:54
@rubo77
Copy link
Contributor

rubo77 commented Dec 25, 2022

Why did you change the order of files? Now they aren't alphabetically anymore

@kesselb
Copy link
Contributor Author

kesselb commented Dec 25, 2022 •
edited
Loading

I appended DESIGN.md to the list and used "Sort Lines" to sort the list.
It seems that "Sort Lines" uses ASCII to sort the lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@rubo77 rubo77 Awaiting requested review from rubo77

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@kesselb @rubo77 @juliusknorr @skjnldsv @szaimen