Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(session): Always setup the session if a session cookie is passed #35866

Merged
merged 1 commit into from
Dec 22, 2022

Conversation

juliusknorr
Copy link
Member

Follow-up fix for #28311 as the merge has shown failures in E2E tests of text.

The issue is that the test pass both a session cookie as well as basic auth which then leads to the session not being opened. If a session cookie is present however we should always proceed with the previous behaviour to setup the session.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 requested review from artonge and come-nc December 22, 2022 10:50
@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 22, 2022
@juliusknorr juliusknorr merged commit 5b64b81 into master Dec 22, 2022
@juliusknorr juliusknorr deleted the bugfix/noid/session-setup-followup branch December 22, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants