Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve password generation for link shares #36093

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Improve password generation for link shares #36093

merged 1 commit into from
Jan 16, 2023

Conversation

PVince81
Copy link
Member

Use web crypto when generating password for link shares whenever the password policy app is disabled.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included => none written also no space to add any for such files
  • Screenshots before/after for front-end changes => not relevant
  • Documentation (manuals or wiki) has been updated or is not required => n/a
  • Backports requested where applicable (ex: critical bugfixes) => unsure

@PVince81 PVince81 added the 3. to review Waiting for reviews label Jan 11, 2023
@PVince81 PVince81 added this to the Nextcloud 26 milestone Jan 11, 2023
@PVince81 PVince81 self-assigned this Jan 11, 2023
artonge
artonge approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick, but good in any case

apps/files_sharing/src/utils/GeneratePassword.js Show resolved Hide resolved
@PVince81
Copy link
Member Author

/backport to stable25

@PVince81
Copy link
Member Author

/backport to stable24

@PVince81
Copy link
Member Author

/backport to stable23

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 16, 2023
@PVince81
Improve password generation for link shares
e9f7ea1 
Use web crypto when generating password for link shares
whenever the password policy app is disabled.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
@PVince81 PVince81 force-pushed the techdebt/noid/improve-share-pw-generation branch from 93eff1c to e9f7ea1 Compare January 16, 2023 13:35
@nickvergessen nickvergessen merged commit 7f81ce5 into master Jan 16, 2023
@nickvergessen nickvergessen deleted the techdebt/noid/improve-share-pw-generation branch January 16, 2023 21:26
This was referenced Jan 16, 2023
Merged
Merged
@backportbot-nextcloud
Copy link

The backport to stable23 failed. Please do this backport manually.

@PVince81 PVince81 mentioned this pull request Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@artonge artonge artonge approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@PVince81 PVince81

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
5 participants
@PVince81 @ChristophWurst @artonge @nickvergessen @skjnldsv