[stable25] Fix/35886 replace custom tooltips with native one for personal and administration settings stable25 #36197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaKirschenheuter
requested review from
ChristophWurst,
julien-nc,
miaulalala,
nickvergessen,
CarlSchwan and
tcitworld
as code owners
JuliaKirschenheuter
requested review from
PVince81 and
Pytal
and removed request for
nickvergessen,
tcitworld,
miaulalala and
CarlSchwan
ChristophWurst
requested changes
Jan 17, 2023
JuliaKirschenheuter
force-pushed
the
fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings-stable25
branch
from
138ae5d
to
6127b03
Compare
apps/settings/src/components/PersonalInfo/shared/FederationControlAction.vue
Show resolved
Hide resolved
nickvergessen
requested changes
Jan 17, 2023
apps/settings/src/components/PersonalInfo/shared/FederationControlAction.vue
Show resolved
Hide resolved
|
Thank you! I will fix that problem as a follow-up ticket on master + will create a follow-up backport to stable25. Could we merge this PR or should i just close this one? |
|
You can also just restore the deleted line in this pr and then we merge? |
JuliaKirschenheuter
force-pushed
the
fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings-stable25
branch
from
9665089
to
5faa82c
Compare
nickvergessen
approved these changes
Jan 19, 2023
FYI this is not how fixup commits are structured. Git won't be able to resolve what commit you are fixing up. |
ChristophWurst
approved these changes
Jan 19, 2023
Pytal
approved these changes
Jan 19, 2023
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
JuliaKirschenheuter
force-pushed
the
fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings-stable25
branch
from
5faa82c
to
d2e50ba
Compare
JuliaKirschenheuter
deleted the
fix/35886-Replace_custom_tooltips_with_native_one_for_personal_and_administration_settings-stable25
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #35901
ToDo