[stable25] fix(theming): fix admin images migration #36272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
ArtificialOwl and
icewind1991
and removed request for
a team
skjnldsv
changed the title
|
/backport to master |
|
Btw, I'd like to go on the record and say I heavily dislike that there is no way to move a folder in appdata. Having to recreate the folder structure and create a new file for each existing one is very cumbersome |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/stable25-fix-theming-admin-migration
branch
from
7581dbb
to
2bdbd7f
Compare
Pytal
approved these changes
Jan 20, 2023
szaimen
added
4. to release
|
@skjnldsv is the problem also already fixed in master? |
|
Ah i see there is a backport to master 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36206
Context
The previous job was just clearing the old images without any migration.
Now we are properly migrating them into global and then cleaning afterwards.