Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Remove Bootstrap version reference from tooltip.scss #36273

Merged
merged 1 commit into from
Jan 20, 2023
Merged

[stable25] Remove Bootstrap version reference from tooltip.scss #36273

merged 1 commit into from
Jan 20, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #35485

@AlvaroBrey @backportbot-nextcloud
Remove Bootstrap version reference from tooltip.scss
95d5641 
We've had some reports that Nextcloud is using an outdated/deprecated Bootstrap version v3.3.5.

I believe this to be caused by the string "Bootstrap v3.3.5" in the changed line, which after bundling ends up in `core-common.js`, and trips up some security scanners.

It may also be worth investigating why the comments are not getting stripped when bundling the JS.

Signed-off-by: Álvaro Brey <alvaro.brv@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.4 milestone Jan 20, 2023
@szaimen szaimen added the 4. to release Ready to be released and/or waiting for tests to finish label Jan 20, 2023
@nickvergessen nickvergessen merged commit 0e69430 into stable25 Jan 20, 2023
@nickvergessen nickvergessen deleted the backport/35485/stable25 branch January 20, 2023 15:24
@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
@nickvergessen nickvergessen mentioned this pull request Feb 28, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@AlvaroBrey AlvaroBrey Awaiting requested review from AlvaroBrey

@artonge artonge Awaiting requested review from artonge

@come-nc come-nc Awaiting requested review from come-nc

@PVince81 PVince81 Awaiting requested review from PVince81

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 25.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @szaimen @AlvaroBrey