Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Bump @nextcloud/vue to v7.5.0 #36322

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 24, 2023

Summary

Backport #36321

  1. Bump vue and vue-template-compiler to fix build errors

  2. Set webpack config resolve.fallback.assert to false to fix build error for client-side only runtime environment:

Module not found: Error: Can't resolve 'assert'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
  - add a fallback 'resolve.fallback: { "assert": require.resolve("assert/") }'
  - install 'assert'
If you don't want to include a polyfill, you can use an empty module like this:
  resolve.fallback: { "assert": false }

Checklist

Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 please solve the conflicts

- Set webpack config `resolve.fallback.assert` to `false` to fix build error:
```
Module not found: Error: Can't resolve 'assert'

BREAKING CHANGE: webpack < 5 used to include polyfills for node.js core modules by default.
This is no longer the case. Verify if you need this module and configure a polyfill for it.

If you want to include a polyfill, you need to:
  - add a fallback 'resolve.fallback: { "assert": require.resolve("assert/") }'
  - install 'assert'
If you don't want to include a polyfill, you can use an empty module like this:
  resolve.fallback: { "assert": false }
```

Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 2f8fb24)
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 24, 2023
@Pytal Pytal merged commit 4c4ed12 into stable25 Jan 24, 2023
@Pytal Pytal deleted the backport/36321/stable25 branch January 24, 2023 19:05
@blizzz blizzz mentioned this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants