Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] Drop vue-clipboard2 in favour of native Clipboard API to fix copy to clipboard #36507

Merged
merged 1 commit into from
Feb 4, 2023
Merged

[stable25] Drop vue-clipboard2 in favour of native Clipboard API to fix copy to clipboard #36507

merged 1 commit into from
Feb 4, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 3, 2023

Summary

Backport #36450

Checklist

@Pytal
Drop vue-clipboard2 to fix copy to clipboard
3b61e38 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit edcf675)
@Pytal Pytal added this to the Nextcloud 25.0.4 milestone Feb 3, 2023
@Pytal Pytal self-assigned this Feb 3, 2023
@Pytal Pytal mentioned this pull request Feb 3, 2023
Merged
4 tasks
jotoeri
jotoeri approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@jotoeri jotoeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also introduces a small visual change on the frontend. 🤔

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 3, 2023
@Pytal Pytal merged commit 9ce68bf into stable25 Feb 4, 2023
@Pytal Pytal deleted the backport/36450/stable25 branch February 4, 2023 00:21
@blizzz blizzz mentioned this pull request Feb 6, 2023
Merged
@juliushaertl juliushaertl mentioned this pull request Mar 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@jotoeri jotoeri jotoeri approved these changes

@artonge artonge Awaiting requested review from artonge

@GretaD GretaD Awaiting requested review from GretaD

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug feature: authentication feature: sharing
Projects
None yet
Milestone
Nextcloud 25.0.4
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @JuliaKirschenheuter @jotoeri @szaimen