Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore copy button text on directory fetch error #36564

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Restore copy button text on directory fetch error #36564

merged 1 commit into from
Feb 8, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Feb 6, 2023 •
edited
Loading

Proxy type to _fillFilePicker and call _changeButtonsText in it when getFolderContents fails.

Before After
Screencast from 2023-02-06 16-39-14.webm Screencast from 2023-02-06 16-38-11.webm

@artonge artonge self-assigned this Feb 6, 2023
@artonge artonge added this to the Nextcloud 26 milestone Feb 6, 2023
@artonge
Copy link
Contributor Author

artonge commented Feb 6, 2023

/backport to stable25

@artonge
Copy link
Contributor Author

artonge commented Feb 6, 2023

/backport to stable24

@artonge artonge force-pushed the artonge/fix/restore_copy_button_text_on_error branch 2 times, most recently from 67828ec to c350670 Compare February 6, 2023 15:05
@artonge artonge changed the title Restore copy button test on directory fetch error Restore copy button text on directory fetch error Feb 6, 2023
@szaimen szaimen requested review from skjnldsv, Pytal, a team and szaimen and removed request for a team February 6, 2023 15:36
@artonge artonge requested a review from a team February 7, 2023 09:10
@artonge
Restore copy button text on directory fetch error
a547aff 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/fix/restore_copy_button_text_on_error branch from c350670 to a547aff Compare February 8, 2023 09:54
szaimen
szaimen approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@artonge artonge merged commit df664ed into master Feb 8, 2023
@artonge artonge deleted the artonge/fix/restore_copy_button_text_on_error branch February 8, 2023 11:00
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

This was referenced Feb 8, 2023
Merged
Merged
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Feb 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug feature: filepicker javascript
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @Pytal @szaimen @skjnldsv