Container optimizations #36613
Closed
Container optimizations #36613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
force-pushed
the
container-optimizations
branch
2 times, most recently
from
23aab0c
to
248e30c
Compare
icewind1991
force-pushed
the
container-optimizations
branch
from
e758c78
to
b902c8c
Compare
Merged
Merged
icewind1991
force-pushed
the
container-optimizations
branch
from
b902c8c
to
fd87c32
Compare
This was referenced May 3, 2023
Merged
Closed
Merged
icewind1991
force-pushed
the
container-optimizations
branch
from
fd87c32
to
3e03251
Compare
| if ($item instanceof ServiceFactory) { | ||
| return $item->get(); | ||
| } elseif (is_callable($item)) { | ||
| $this->items[$name] = $item($this); |
Check failure
Code scanning / Psalm
TaintedCallable Error
| if ($item instanceof ServiceFactory) { | ||
| return $item->get(); | ||
| } elseif (is_callable($item)) { | ||
| $this->items[$name] = $item($this); |
Check failure
Code scanning / Psalm
TaintedCallable Error
| if ($item instanceof ServiceFactory) { | ||
| return $item->get(); | ||
| } elseif (is_callable($item)) { | ||
| $this->items[$name] = $item($this); |
Check failure
Code scanning / Psalm
TaintedCallable Error
AndyScherzinger
force-pushed
the
container-optimizations
branch
from
3e03251
to
1477947
Compare
Merged
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…r when instances are already created Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
container-optimizations
branch
from
1477947
to
4074848
Compare
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various minor optimization to the DI container that add up since we query the container a lotRipped out pimple altogether, we were barely using it's more advanced features anyway and it was mostly just getting in the way