fix(database): Fix public_key_credential_id length #36769
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * @param array $options | ||
| * @return null|ISchemaWrapper | ||
| */ | ||
| public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { |
Check failure
Code scanning / Psalm
UndefinedClass Error
Merged
Merged
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
9 tasks
zevlee
force-pushed
the
fix-public-key-credential-id
branch
from
0263eed
to
8c1913e
Compare
| class Version25000Date20230217195657 extends SimpleMigrationStep { | ||
| public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper { | ||
| /** @var ISchemaWrapper $schema */ | ||
| $schema = $schemaClosure(); |
Check failure
Code scanning / Psalm
UndefinedDocblockClass Error
| /** @var ISchemaWrapper $schema */ | ||
| $schema = $schemaClosure(); | ||
|
|
||
| $registrationsTable = $schema->getTable('webauthn'); |
Check failure
Code scanning / Psalm
UndefinedDocblockClass Error
| ->getColumn('public_key_credential_id') | ||
| ->setLength(512); | ||
|
|
||
| return $schema; |
Check failure
Code scanning / Psalm
InvalidReturnStatement Error
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
Merged
4 tasks
|
Solved by #47240 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Increases length of column for security key so that it fits. This is essentially an identical migration step to nextcloud/twofactor_webauthn#323.
Checklist