fix: Use shortestName instead of sequenceName for Postgres seqence migration #36791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
requested review from
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
…name is not referenced in column_default Signed-off-by: Jean-Baptiste Molle <jb.molle@vescape.com>
Signed-off-by: Jean-Baptiste Molle <jb.molle@vescape.com>
Merged
vitormattos
approved these changes
May 3, 2023
Merged
Merged
This was referenced Mar 12, 2024
Merged
Merged
Merged
skjnldsv
added
2. developing
Merged
|
Hey @jbmolle! We're actively testing our server with pgsql from 12 to 16 (at the time of this comment), is there still an issue with this then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sequence migration fails on Postgres 15 because the sequenceName contains Postgres schema name which is not public.
Access to the public schema has been removed in Postgres 15. If a schema with the name of the user exists, it is going to be used per default. The sequenceName contains the schema name and it is better to use the shortestName.
Checklist