Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set notification email automatically after deleting additional email #36812

Closed
wants to merge 1 commit into from

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 23, 2023

Summary

When an additional email is set as the notification email and is deleted, the deleted email will remain as the notification email

This is unexpected behaviour so we fix this by automatically setting the system email as the notification email on deletion

Additional email as notification email

image

After deletion

Screenshot
Before image
After image

Checklist

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 26 milestone Feb 23, 2023
@Pytal Pytal requested review from blizzz, artonge and szaimen February 23, 2023 00:41
@Pytal Pytal self-assigned this Feb 23, 2023
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to do the change on the backend side instead of here?

@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
@blizzz blizzz mentioned this pull request Mar 7, 2023
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 7, 2023
This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@nextcloud nextcloud deleted a comment from Pytal Feb 24, 2024
@nextcloud nextcloud deleted a comment from Pytal Feb 24, 2024
@skjnldsv
Copy link
Member

Would it make sense to do the change on the backend side instead of here?

I agree with Louis @Pytal :)

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Feb 24, 2024
@blizzz
Copy link
Member

blizzz commented Feb 27, 2024

also would prefer it on the backend side

This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv
Copy link
Member

skjnldsv commented May 2, 2024

Closing this pull request due to lack of recent activity and updates; also seeing the two comments about backend :)

@skjnldsv skjnldsv closed this May 2, 2024
@skjnldsv skjnldsv deleted the fix/additional-notification-email branch May 2, 2024 15:27
@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants