-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set notification email automatically after deleting additional email #36812
Conversation
Signed-off-by: Christopher Ng <chrng8@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to do the change on the backend side instead of here?
I agree with Louis @Pytal :) |
also would prefer it on the backend side |
Closing this pull request due to lack of recent activity and updates; also seeing the two comments about backend :) |
Summary
When an additional email is set as the notification email and is deleted, the deleted email will remain as the notification email
This is unexpected behaviour so we fix this by automatically setting the system email as the notification email on deletion
Additional email as notification email
After deletion
Checklist