Replace "Edit" by "Open" because opening locally does not necessarily mean "editing" (but simply "viewing")

[Jerome-Herbinet]

Signed-off-by: Jérôme Herbinet 33763786+Jerome-Herbinet@users.noreply.github.com

Fixes #37058

Summary

The term "edit" is too restrictive, as many file types are only "edited" in rare cases. E.g.: Videos, PDF documents, audio files, etc. Frank Karlitschek said at the Nextcloud Conf in Berlin that this local opening feature can work with any file whose MIME type is linked to software on the computer. Therefore, it is important to have a more general wording that is suitable for both viewing and editing.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nimishavijay]

It is true that you may not be able to edit it the entire time, so "open" may be more applicable generally. However, changing it to "open" runs the risk of the feature being underutilised as I would assume the main use case is to edit locally 🤔 What do you think @jancborchardt

[szaimen]

I'd agree with thid change 👍
So Open locally is better imho.

[skjnldsv]

Done @skjnldsv ! Do I need to rebase ?

Yes, as well as fixing tests
https://github.com/Jerome-Herbinet/server/blob/f65d549c862b30bfca2ad8dc84642fd7ac2c8c47/apps/files/src/actions/editLocallyAction.spec.ts#L37

[Jerome-Herbinet]

Not sure to understand if there is a problem with that PR ? Something missing ?

[jancborchardt]

@skjnldsv "Open locally" was approved by design, could we not just merge this?

[skjnldsv]

@Jerome-Herbinet please adjust your commits messages. You need to follow the conventional commits convention
I suggest something like fix: rename 'edit locally' to 'open locally'

Please also squash them together into one commit, there is no reason to split them ;)

The tests also needs adjusting, as mentioned above :)
https://github.com/nextcloud/server/actions/runs/10878943385/job/30182746981?pr=36831