fix(provisionning_api): Remove parameters that are not set into template #37303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
blizzz,
a team,
icewind1991 and
come-nc
and removed request for
a team
|
/backport to stable26 |
This was referenced May 3, 2023
Merged
Closed
Merged
Merged
Merged
tcitworld
force-pushed
the
remove-unset-parameters
branch
from
7c962c4
to
c372ee3
Compare
|
Since it's pretty clear this thing is not used from any other point, let's move it also into the app, to avoid it being in core/ and therefore seen as "public API" |
AndyScherzinger
force-pushed
the
remove-unset-parameters
branch
from
c372ee3
to
31fef6b
Compare
Merged
Merged
Merged
provokateurin
approved these changes
Aug 26, 2024
kesselb
approved these changes
Aug 28, 2024
ChristophWurst
added
4. to release
skjnldsv
approved these changes
Aug 28, 2024
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
provokateurin
force-pushed
the
remove-unset-parameters
branch
from
31fef6b
to
aa8df9b
Compare
|
Rebased to fix CI 👍 |
This was referenced Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
Notice: Undefined index: parametersWarning: Invalid argument supplied for foreach()Undefined index: targetUrl at /var/www/nc/nextcloud/core/templates/confirmation.php#9The template is only called by the Provisioning API in
apps/provisioning_api/lib/Controller/VerificationController.php, brought in #28422.Checklist