Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] Ungroup placeholder css rules to prevent browsers from removing all rules #37793

Merged
merged 1 commit into from
May 17, 2023
Merged

[stable26] Ungroup placeholder css rules to prevent browsers from removing all rules #37793

merged 1 commit into from
May 17, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Apr 18, 2023 •
edited by szaimen
Loading

  • ⚠️ This backport had conflicts that were resolved with the 'ours' merge strategy and is likely incomplete

backport of #37522

@backportbot-nextcloud backportbot-nextcloud bot added bug design Design, UI, UX, etc. labels Apr 18, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.1 milestone Apr 18, 2023
@szaimen
Copy link
Contributor

szaimen commented Apr 18, 2023

/compile amend /

@szaimen szaimen added the 3. to review Waiting for reviews label Apr 18, 2023
@szaimen szaimen marked this pull request as ready for review April 18, 2023 11:42
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 18, 2023
@susnux
Copy link
Contributor

susnux commented Apr 19, 2023

Drone error is unrelated.

@blizzz blizzz mentioned this pull request May 16, 2023
Merged
@blizzz
Copy link
Member

blizzz commented May 17, 2023

conflicts

@susnux
fix(core): Ungroup placeholder css rules to prevent browsers from r…
25cde39 
…emoving all rules

When rules are grouped using the comma operator and one selector is invalid / unknown then the whole group is invalidated[1].
In this case `::-ms-input-placeholder` is unknown to Firefox and Chrome, so the `::placeholder` rule is never applied.
[1]: https://www.w3.org/TR/selectors-3/#grouping

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented May 17, 2023

conflicts

@blizzz resolved

@susnux susnux enabled auto-merge May 17, 2023 13:03
@blizzz
Copy link
Member

blizzz commented May 17, 2023

→ 26.0.3

@susnux susnux merged commit a01a15c into stable26 May 17, 2023
@susnux susnux deleted the backport/37522/stable26 branch May 17, 2023 19:12
@blizzz blizzz mentioned this pull request May 24, 2023
Merged
@blizzz
Copy link
Member

blizzz commented May 24, 2023

Merged after RC1, will revert

@blizzz blizzz mentioned this pull request May 24, 2023
Merged
@susnux susnux restored the backport/37522/stable26 branch May 26, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen szaimen approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 26.0.3
Development

Successfully merging this pull request may close these issues.
5 participants
@szaimen @susnux @blizzz @Pytal @skjnldsv